-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop unmaintained pygeos for shapely 2.0 #545
Conversation
(Issue tracked here: #432) |
thanks @omsai for this PR, I wonder we could probably also remove this right https://github.com/scverse/spatialdata/blob/main/src/spatialdata/_compat.py#L1 ? |
@giovp Indeed; I've dropped that as well. |
thank you @omsai , I think it should be fine to not have it backward compatible, would like to have other devs chime in |
Thanks for the PR! I have also tested it, with Python 3.12, and all works as expected. Minor comment, I have removed the line |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #545 +/- ##
==========================================
+ Coverage 92.53% 92.55% +0.01%
==========================================
Files 43 42 -1
Lines 6003 6000 -3
==========================================
- Hits 5555 5553 -2
+ Misses 448 447 -1
|
codecov woke up after 3 months 😅 |
The requirement pygeos fails to install with python 3.12 with the error described here: pygeos/pygeos#463
The maintainer explains that pygeos is no longer maintained and has been merged into the shapley 2.0 dependency of geopandas. Since version 0.14, geopandas uses shapley instead of pygeos: https://geopandas.org/en/stable/docs/user_guide/pygeos_to_shapely.html
Therefore, the PR drops the unmaintained pygeos and requires geopandas >= 0.14 to ensure the default shapley version is used instead.