Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop unmaintained pygeos for shapely 2.0 #545

Merged
merged 2 commits into from
May 24, 2024

Conversation

omsai
Copy link
Contributor

@omsai omsai commented Apr 16, 2024

The requirement pygeos fails to install with python 3.12 with the error described here: pygeos/pygeos#463

The maintainer explains that pygeos is no longer maintained and has been merged into the shapley 2.0 dependency of geopandas. Since version 0.14, geopandas uses shapley instead of pygeos: https://geopandas.org/en/stable/docs/user_guide/pygeos_to_shapely.html

Therefore, the PR drops the unmaintained pygeos and requires geopandas >= 0.14 to ensure the default shapley version is used instead.

@clwgg
Copy link
Contributor

clwgg commented Apr 16, 2024

(Issue tracked here: #432)

@giovp
Copy link
Member

giovp commented Apr 23, 2024

thanks @omsai for this PR, I wonder we could probably also remove this right https://github.com/scverse/spatialdata/blob/main/src/spatialdata/_compat.py#L1 ?

@omsai
Copy link
Contributor Author

omsai commented Apr 23, 2024

@giovp Indeed; I've dropped that as well.

@giovp
Copy link
Member

giovp commented Apr 23, 2024

thank you @omsai , I think it should be fine to not have it backward compatible, would like to have other devs chime in

@giovp giovp requested review from LucaMarconato and melonora April 23, 2024 17:00
@LucaMarconato
Copy link
Member

Thanks for the PR! I have also tested it, with Python 3.12, and all works as expected.

Minor comment, I have removed the line os.environ["USE_PYGEOS"] = "0" from spatialdata/tests/conftest.py (and from other scripts in the ecosystem) because now it'd not needed anymore. Some notebooks still have it, so if we see it let's remove it (but no rush, that line currently has no effect).

@LucaMarconato LucaMarconato linked an issue May 24, 2024 that may be closed by this pull request
@LucaMarconato LucaMarconato merged commit ece4de4 into scverse:main May 24, 2024
4 of 6 checks passed
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.55%. Comparing base (b73f3a8) to head (0acc495).
Report is 91 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #545      +/-   ##
==========================================
+ Coverage   92.53%   92.55%   +0.01%     
==========================================
  Files          43       42       -1     
  Lines        6003     6000       -3     
==========================================
- Hits         5555     5553       -2     
+ Misses        448      447       -1     
Files Coverage Δ
src/spatialdata/__init__.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

@LucaMarconato
Copy link
Member

codecov woke up after 3 months 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove pygeos dependency
4 participants