Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix str column showing object dtype #489

Merged
merged 1 commit into from
Mar 15, 2024
Merged

Conversation

melonora
Copy link
Collaborator

The table validation currently fails when the instance_key column contains str values. This is because when setting the dtype of such a column to str, the dtype is actually object. This PR corrects the check so that an instance_key column having the object dtype and having as first element a str value, would still pass the check.

Copy link

codecov bot commented Mar 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.58%. Comparing base (c2e4ef9) to head (4101557).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #489   +/-   ##
=======================================
  Coverage   92.58%   92.58%           
=======================================
  Files          43       43           
  Lines        5866     5867    +1     
=======================================
+ Hits         5431     5432    +1     
  Misses        435      435           
Files Coverage Δ
src/spatialdata/models/models.py 88.02% <100.00%> (+0.02%) ⬆️

@melonora melonora merged commit 4166360 into scverse:main Mar 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant