-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes on dataloaders #439
Fixes on dataloaders #439
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #439 +/- ##
==========================================
+ Coverage 92.58% 92.63% +0.05%
==========================================
Files 43 43
Lines 5867 5894 +27
==========================================
+ Hits 5432 5460 +28
+ Misses 435 434 -1
|
CC @giovp |
Further fixes are introduced with https://github.com/scverse/spatialdata/pull/495/files. |
This PR improves the
ImageTilesDataset
class in the following ways.rasterize
isTrue
orFalse
. The output is always a single scale image.to_circles()
API; in particular in_get_tile_coords()
there is no need anymore to perform affine matrix multiplications manually.polygon.length
. Before if the regions were polygons or multipolygons, the perimeter of these polygon would have been used as the tile width/height. This contrasted with the usage of the diameter for circles. Now any region element is transformed to circles element usingto_circles()
and the tile sizes are the diameters of these circles.