Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unpin typing extensions #372

Merged
merged 1 commit into from
Oct 9, 2023
Merged

unpin typing extensions #372

merged 1 commit into from
Oct 9, 2023

Conversation

giovp
Copy link
Member

@giovp giovp commented Oct 9, 2023

spatialdata pins typing extensions for some reasons that I don't remember, but it often conflicts with other packages in the same env. Would like to merge this asap

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #372 (43acff7) into main (46fa478) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #372   +/-   ##
=======================================
  Coverage   90.61%   90.61%           
=======================================
  Files          36       36           
  Lines        4700     4700           
=======================================
  Hits         4259     4259           
  Misses        441      441           

@giovp giovp requested a review from LucaMarconato October 9, 2023 15:03
@LucaMarconato
Copy link
Member

LucaMarconato commented Oct 9, 2023

The change was done here: #279, I think it was to be able to install napari on M1 chips.

I have just tried the installation of every repo, including napari, and it works on my M1 Mac. So good to go!

@LucaMarconato LucaMarconato merged commit 14bf585 into main Oct 9, 2023
@LucaMarconato LucaMarconato deleted the install/typing_extensions branch October 9, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants