Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pre-release test #371

Closed
wants to merge 1 commit into from
Closed

added pre-release test #371

wants to merge 1 commit into from

Conversation

LucaMarconato
Copy link
Member

@ivirshup can you review please?

@LucaMarconato LucaMarconato requested a review from ivirshup October 8, 2023 18:22
@LucaMarconato
Copy link
Member Author

Let's see if the jobs succeeds, but it seems to be working 😊

@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #371 (0e09c3e) into main (46b6912) will increase coverage by 0.03%.
Report is 3 commits behind head on main.
The diff coverage is 91.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #371      +/-   ##
==========================================
+ Coverage   90.57%   90.61%   +0.03%     
==========================================
  Files          36       36              
  Lines        4692     4700       +8     
==========================================
+ Hits         4250     4259       +9     
+ Misses        442      441       -1     
Files Coverage Δ
src/spatialdata/_core/query/relational_query.py 91.82% <91.66%> (+1.09%) ⬆️

@ivirshup
Copy link
Member

ivirshup commented Oct 8, 2023

Looks kinda like #370 😉

@LucaMarconato LucaMarconato added the CI ∫ Related to Continuous Integration label Oct 8, 2023
@LucaMarconato
Copy link
Member Author

Nice 😁 Gonna merge yours, but with macOS. In this way if something breaks we can test it locally, and also in this way we test both Python 3.9 and 3.10 with macOS (one in normal mode and one in pre-release mode).

@LucaMarconato LucaMarconato deleted the tests/pre-release branch October 8, 2023 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI ∫ Related to Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants