-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata GDSC annotation improvements #625
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! The GDSC string change is fine with me. I would also even argue that it should be a Literal
or the two string options @wxicu ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the improvement! Literal
of gdsc dataset sounds good to me
@Lilly-May can you change this so that we use string literals for the dataset names? Maybe |
Sure! But you still want it to work with integers as well, right? So something like |
I'd drop support for integers |
Description of changes
1
or2
and otherwise throw an error.annotate_from_gdsc
method, which now uses the correct GDSC data to compute. Previously, the code would fail for me if GDSC2 was used.Statsmodel
example. I believe an old class name might have been used here. It's still not a working example as theadata
is not defined, but I think it is much easier for users to understand now.