Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pseudobulk improvements #529

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Pseudobulk improvements #529

merged 1 commit into from
Feb 7, 2024

Conversation

Lilly-May
Copy link
Collaborator

PR Checklist

Description of changes

  • Added a parameter explanation for the groups_col parameter. There are use cases where one might want to specify groups to consider in addition to the perturbation. That way, one can, for example, summarize perturbations for each cell type individually, so that the resulting pseudobulk object would have separate datapoints for pert1_celltype1, pert1_celltype2, and so on. However, the default setting for this parameter should be None, and the parameter should be explained in the docs.
  • Deleted groups_col parameter from the docs example (previously, groups_col was set to the same value as target_col, which is useless since decoupler then internally sets groups_col to None again, see code here).
  • Added cast for .obs column storing the perturbation labels to category type

Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Zethson Zethson merged commit 423063f into main Feb 7, 2024
3 of 7 checks passed
@Zethson Zethson deleted the feature/pseudobulk_improvements branch May 20, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pseudobulk space improvements
2 participants