Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PertSpace docs improvements #471

Merged
merged 5 commits into from
Dec 27, 2023
Merged

Conversation

Lilly-May
Copy link
Collaborator

@Lilly-May Lilly-May commented Dec 27, 2023

PR Checklist

  • Documentation in docs is updated

Description of changes

While skimming the PertSpace documentation, I observed that the documentation could benefit from minor improvements. Specifically, I did the following:

  • Corrected example formatting (e.g., identified broken formatting here).
  • Ensured that all PertSpace methods specify the return type and include a description of what they return, if applicable.
  • Added explanations for some missing parameters.
  • Switch to pandas.DataFrame.iloc for index based selection to silence FutureWarning

@github-actions github-actions bot added the enhancement New feature or request label Dec 27, 2023
Copy link

codecov bot commented Dec 27, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (63217f7) 62.92% compared to head (e066504) 62.92%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   62.92%   62.92%           
=======================================
  Files          41       41           
  Lines        4637     4637           
=======================================
  Hits         2918     2918           
  Misses       1719     1719           
Files Coverage Δ
pertpy/tools/_perturbation_space/_clustering.py 97.36% <ø> (ø)
...y/tools/_perturbation_space/_perturbation_space.py 85.79% <ø> (ø)
pertpy/tools/_perturbation_space/_simple.py 75.22% <ø> (ø)
...s/_perturbation_space/_discriminator_classifier.py 90.25% <0.00%> (ø)

Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@Zethson Zethson merged commit 0879d41 into main Dec 27, 2023
7 of 8 checks passed
@Lilly-May Lilly-May deleted the feature/pertspace_docs_improvements branch December 27, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants