Added smillie_2019 dataloader and renamed smillie dataset to tasccoda_example #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Lukas Heumos <[email protected]>
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #450 +/- ##
=======================================
Coverage 57.83% 57.83%
=======================================
Files 40 40
Lines 4933 4933
=======================================
Hits 2853 2853
Misses 2080 2080
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docsis updated (description of datasets)Description of changes
Added the
smillie_2019()dataset, which is now accessible via the dataloader. Initially, we observed that the tascCODA tutorial reads a local file instead of one from the pertpy dataloader, making it challenging for users to reproduce the tutorial. Hence, we decided to include the dataset containing both count data and detailed annotation required for processing with tascCODA.To avoid confusion, I renamed the previously labeled
smillie()dataset totasccoda_example(). The dataset doesn't actually contain smillie's count data, only themudata['coda']part. Since it's still a useful dataset for testing tascCODA due to its smaller size, we chose to keep it but under a different name. I also updated all occurrences (in one tasccoda test and several docs examples) ofpt.dt.smillie()topt.dt.tasccoda_example().Technical details
The smillie_2019() dataset was created using this notebook.