-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace plotnine implementation of barplot with seaborn/matplotlib #441
Conversation
Removed the dependency (plotnine)
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
==========================================
- Coverage 58.23% 57.83% -0.41%
==========================================
Files 40 40
Lines 4899 4933 +34
==========================================
Hits 2853 2853
- Misses 2046 2080 +34
|
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Thank you very much!
- Could you please remove plotnine from the dependencies from
pyproject.toml
? - Could you please paste a before and after plot here? Like one with the old plotnine implementation and one with your new implementation
- We have a lot of hardcoded plot parameters now (like
s
,alpha,
, and more). Which ones do you think we should expose to the user? Should we populate them at least with kwargs?
Thanks!
Have removed the commented sentence at line 112 and have changed the variable name from "I" to "cond" (meaning condition)
I have removed the name of the dependency (plotnine)
we can expose s and alpha to the user since s:marker size and alpha: transparency parameter, for that we can make the use of kwargs. |
Before and after by @kcArtemis |
This comment was marked as off-topic.
This comment was marked as off-topic.
Updated "p" variable to "plot_dens" and change the legend title from "mix" to "mix scape_class"
Removed the dependency (plotnine)
PR Checklist
docs
is updatedDescription of changes
In this pull request, I addressed the issue #425 by removing the dependency on plotnine. Instead, I have implemented the use of matplotlib and seaborn for plotting. Specifically, I updated the
barplot
function and theperturbscore
function to utilize these libraries, providing a more lightweight solution for the project.Technical details
While making these changes, I ensured that the functionality remains consistent, and the transition to matplotlib and seaborn is seamless. The choice of these libraries was made to minimize dependencies and provide a more straightforward solution for users. No additional dependencies are introduced, and the overall performance is maintained.
Additional context