Update _mixscape.py #440
Closed
Update _mixscape.py #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed plotnine dependencies
for more information, see https://pre-commit.ci
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #440 +/- ##
==========================================
- Coverage 58.23% 57.82% -0.41%
==========================================
Files 40 40
Lines 4899 4932 +33
==========================================
- Hits 2853 2852 -1
- Misses 2046 2080 +34
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed plotnine dependencies
PR Checklist
docsis updatedDescription of changes
In this pull request, I addressed the issue #425 by removing the dependency on plotnine. Instead, I have implemented the use of matplotlib and seaborn for plotting. Specifically, I updated the
barplotfunction and theperturbscorefunction to utilize these libraries, providing a more lightweight solution for the project.Technical details
While making these changes, I ensured that the functionality remains consistent, and the transition to matplotlib and seaborn is seamless. The choice of these libraries was made to minimize dependencies and provide a more straightforward solution for users. No additional dependencies are introduced, and the overall performance is maintained.
Additional context