-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code coverage #432
Merged
Merged
Fix code coverage #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flying-sheep
changed the title
Add codecov logging and function check
Fix code coverage
Nov 10, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
==========================================
+ Coverage 0.00% 58.23% +58.23%
==========================================
Files 40 40
Lines 4899 4899
==========================================
+ Hits 0 2853 +2853
+ Misses 4899 2046 -2853 |
flying-sheep
commented
Nov 10, 2023
flying-sheep
commented
Nov 10, 2023
Zethson
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much!
flying-sheep
commented
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description of changes
coverage
directly instead of usingpytest-cov
Technical details
Using
pytest-cov
can sometimes cause problems since it initializes its machinery after pytest has started doing its thing.coverage run
will work in those circumstances.Of course that means that pytest can’t prevent adding the current working directory to PYTHONPATH unless the project uses the
src
layout. Experimentally switching the project to src layout worked, but I think that’s out of scope for this PR.Additional context