Implementation of CINEMA-OT for pertpy #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Zethson
reviewed
Sep 15, 2023
There was a problem hiding this comment.
Thank you very much for the really fast contribution!
- I made a couple of minor corrections and removed unused imports and parameters. Feel free to checkout my last commit if I deleted a parameter that you actually wanted to implement.
- I've uploaded your test dataset to our figshare and wrote a dataloader for it.
- I rewrote your tests with a fixture.
FAILED tests/tools/test_cinemaot.py::TestCinemaot::test_pseudobulk - TypeError: Setting a MultiIndex dtype to anything other than object is not supportedThis test seems to fail? Could you please try to fix it?- In an ideal world, the tests would also test not just that the code runs but that the results are also within some expected range.
|
@MingzeDong I'll merge this today but it'd be really awesome if you could submit a follow up PR with a few improved tests and the failing test being fixed.
Thank you so much! |
|
Thanks! I have submitted a follow up PR and will submit a tutorial notebook later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of CINEMA-OT using the ott-jax library. Including an updated usage.md, tl.Cinemaot class and CinemaotPlot class. A test file is included. Let me know if there are any issues.