Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve mixscape documentation & fix a bug #222

Merged
merged 7 commits into from
Mar 30, 2023
Merged

improve mixscape documentation & fix a bug #222

merged 7 commits into from
Mar 30, 2023

Conversation

xinyuejohn
Copy link
Collaborator

@xinyuejohn xinyuejohn commented Mar 24, 2023 •
edited
Loading

PR Checklist

  • Referenced issue is linked
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

Description of changes

  1. Change "control" argument in mixscape as required arguments
  2. Fix bug in mixscape
  3. Improve mixscape documentation

Technical details

Additional context

@github-actions github-actions bot added the bug Something isn't working label Mar 24, 2023
This was linked to issues Mar 24, 2023
clearer dataset requirements for mixscape #210
Closed
Mixscape data type error #219
Closed
Zethson
Zethson reviewed Mar 24, 2023
View reviewed changes
pertpy/plot/_mixscape.py Outdated Show resolved Hide resolved
@xinyuejohn xinyuejohn marked this pull request as ready for review March 27, 2023 08:09
@xinyuejohn xinyuejohn requested a review from Zethson March 27, 2023 08:09
@Zethson Zethson changed the title improve mixscape improve mixscape documentation & fix a bug Mar 28, 2023
Zethson
Zethson approved these changes Mar 28, 2023
View reviewed changes
pertpy/plot/_mixscape.py Outdated Show resolved Hide resolved
@Zethson Zethson merged commit 255f9a9 into development Mar 30, 2023
@xinyuejohn xinyuejohn deleted the fix/mixscape_improvment branch March 30, 2023 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zethson Zethson Zethson approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mixscape data type error clearer dataset requirements for mixscape
2 participants
@xinyuejohn @Zethson