Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instance id shift bug; fix obsm viz; fix background color labels #320

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

LucaMarconato
Copy link
Member

@LucaMarconato LucaMarconato commented Sep 30, 2024

Closes #242

Fixed:

  • bugs with layer.properties:
  • plotting a continuous variable on a labels caused:
    • the background color to be black instead of transparent; now it's transparent
    • the first instance (no matter which index, for instance 2) to be black, instead of being of a different color
  • plotting variables on obsm was not working
  • the coloring of categorical variables via pre-saved colors was not working because there was a "_color" instead of "_colors"
  • there were some imprecisions in the tests for the scatterplot widget:
    • the table was not parsed using TableModel
    • an unused (and wrong) region_key parameter was passed; I removed it
  • some modifications in the docs; in particular I warn the user that when zooming in on points in macOS one needs to be careful when looking at the values of points on mouse hover. In fact points that seem to be far away could still be overlapping. Example here: circles getting smaller when zooming in #35 (comment)

Missing (I will track these are new issues)

  • tests for plotting data from obsm
  • tests for hovering with the mouse and checking that the status bar of the viewer shows the correct value

@LucaMarconato LucaMarconato merged commit f84b79b into main Oct 1, 2024
7 checks passed
@LucaMarconato LucaMarconato deleted the fix/instance_id_shift branch October 1, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

color legend for categorical annoation in table
1 participant