Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOML formatting using taplo #225

Closed
wants to merge 20 commits into from
Closed

TOML formatting using taplo #225

wants to merge 20 commits into from

Conversation

flying-sheep
Copy link
Member

@flying-sheep flying-sheep commented Aug 11, 2023

Fixes #212, finally!

an alternative to #299, see #212 for a comparison (taplo is now directly published to PyPI, which makes this hook a nice, perfectly integrated alternative)

Outstanding questions:

  1. should we customize taplo more than just with the spaces? E.g. “never collapse multiline arrays” might be desirable. For reference here: Support for .editorconfig files tamasfe/taplo#358
  2. do we prefer TOML formatting using pyproject-fmt #299?

@github-actions
Copy link

A PR has been generated to the instance repo:
scverse/cookiecutter-scverse-instance#82

You can check out the PR to preview your changes
in an instance of the cookiecutter template. The PR will be kept in sync with
this PR automatically.

@flying-sheep flying-sheep marked this pull request as ready for review February 7, 2024 10:18
@flying-sheep flying-sheep marked this pull request as draft February 7, 2024 10:18
@flying-sheep flying-sheep marked this pull request as ready for review August 23, 2024 09:49
@flying-sheep flying-sheep requested a review from grst August 23, 2024 09:53
@flying-sheep flying-sheep changed the title add taplo formatting TOML formatting using taplo Aug 23, 2024
@flying-sheep
Copy link
Member Author

Closing in favor of #299, see comments there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TOML formatting
1 participant