Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor rewording of precommit docs #151

Merged
merged 9 commits into from
Mar 8, 2023
Merged

Minor rewording of precommit docs #151

merged 9 commits into from
Mar 8, 2023

Conversation

ivirshup
Copy link
Member

Collapses ruff checks into other pre commit checks.

Unifies section on how to modify pre-commit checks.

@github-actions
Copy link

A PR has been generated to the instance repo:
scverse/cookiecutter-scverse-instance#39

You can check out the PR to preview your changes
in an instance of the cookiecutter template. The PR will be kept in sync with
this PR automatically.

@ivirshup ivirshup marked this pull request as ready for review February 22, 2023 18:58
@ivirshup ivirshup requested review from flying-sheep and grst and removed request for flying-sheep February 22, 2023 18:58
@ivirshup
Copy link
Member Author

Rewrote some of the relevant sections.

Test failure seems to be codecov on the instance repo?

@grst
Copy link
Collaborator

grst commented Feb 23, 2023

The ruff link renders incorrectly
image

Copy link
Collaborator

@grst grst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@grst grst enabled auto-merge (squash) March 7, 2023 17:38
@grst grst requested a review from flying-sheep March 7, 2023 17:39
@grst
Copy link
Collaborator

grst commented Mar 7, 2023

@flying-sheep, are you happy with this now?

Copy link
Member

@flying-sheep flying-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m happy! just wanted to make sure everyone is aware of the changed terminology

@grst grst merged commit 57f6267 into main Mar 8, 2023
@grst grst deleted the cleanup-precommit-docs branch March 8, 2023 11:39
@ivirshup
Copy link
Member Author

ivirshup commented Mar 8, 2023

Thanks for cleaning this up @grst and @flying-sheep!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants