Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template sync due to lacking permissions #137

Merged
merged 1 commit into from
Jan 9, 2023
Merged

Conversation

grst
Copy link
Collaborator

@grst grst commented Jan 9, 2023

In a test-run, the template sync failed since apparently
the sync.yaml action is not permitted to make changes to files in the
.github/workflows directory:
https://github.com/icbi-lab/infercnvpy/actions/runs/3875431171/jobs/6607954535

This is a bit of a problem for which we still need to figure out a
solution. One of them is to use a personal access token. Another one
could be to centralize template sync, which I would have liked to avoid.

For now, I just rolled back the changes to the workflow files since
the last release since they were mostly of cosmetic nature.

In a test-run, the template sync failed since apparently
the `sync.yaml` action is not permitted to make changes to files in the
`.github/workflows` directory.

This is a bit of a problem for which we still need to figure out a
solution. One of them is to use a personal access token. Another one
could be to centralize template sync, which I would have liked to avoid.

For now, I just rolled back the changes to the workflow files since
the last release since they were mostly of cosmetic nature.
@github-actions
Copy link

github-actions bot commented Jan 9, 2023

A PR has been generated to the instance repo:
scverse/cookiecutter-scverse-instance#35

You can check out the PR to preview your changes
in an instance of the cookiecutter template. The PR will be kept in sync with
this PR automatically.

@grst
Copy link
Collaborator Author

grst commented Jan 9, 2023

@Zethson, another one please.

Actually the underlying issue is pretty nasty -- something I wasn't aware of when setting up template sync. But this should at least be enough to make the nightly cron job pass again for now.

Copy link
Member

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right.

@Zethson Zethson merged commit 7cc5403 into main Jan 9, 2023
@Zethson Zethson deleted the fix-template-sync branch January 9, 2023 16:27
@grst
Copy link
Collaborator Author

grst commented Jan 9, 2023

thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants