Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add post gen hook with detailed instructions #131

Merged
merged 3 commits into from
Dec 19, 2022
Merged

Add post gen hook with detailed instructions #131

merged 3 commits into from
Dec 19, 2022

Conversation

grst
Copy link
Collaborator

@grst grst commented Dec 9, 2022

Close #83

@grst grst requested a review from giovp December 9, 2022 14:59
giovp
giovp approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@giovp giovp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok for me but don't see as super problematic to have rich as dependency for the template

@grst
Copy link
Collaborator Author

grst commented Dec 9, 2022

it's more about people forgetting to install it (needs to be done manually along cruft) and then the whole creation fails at the very end because of that.

@grst grst merged commit 28d3bd0 into main Dec 19, 2022
@grst grst deleted the post-gen-hook branch December 19, 2022 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovp giovp giovp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add post-gen hook that prints further instructions
2 participants
@grst @giovp