Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat): swap out zarr categorical array for xarray #946

Merged
merged 18 commits into from
Mar 16, 2023

Conversation

ilan-gold
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #946 (0d8511a) into ig/read_remote_dispatched (f4f5c7c) will increase coverage by 0.14%.
The diff coverage is 93.75%.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           ig/read_remote_dispatched     #946      +/-   ##
=============================================================
+ Coverage                      83.07%   83.22%   +0.14%     
=============================================================
  Files                             38       38              
  Lines                           5039     5042       +3     
=============================================================
+ Hits                            4186     4196      +10     
+ Misses                           853      846       -7     
Impacted Files Coverage Δ
anndata/experimental/read_remote/read_remote.py 62.30% <93.54%> (+4.32%) ⬆️
anndata/experimental/read_remote/__init__.py 100.00% <100.00%> (ø)

@ilan-gold
Copy link
Contributor Author

@ivirshup do you mind if I leave the xarray dependency for now and then we can double back to this?

@ivirshup
Copy link
Member

ivirshup commented Mar 9, 2023

Fine to leave for now. Can this get tests?

@ilan-gold ilan-gold merged commit 60fae25 into ig/read_remote_dispatched Mar 16, 2023
@ilan-gold ilan-gold deleted the ig/remote_categorical branch March 16, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants