-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ref paths #342
Closed
Closed
Ref paths #342
Changes from 13 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
faae00e
almost done!
flying-sheep 328f5ee
Getting vectors works
flying-sheep d35154b
Implement RefPath.dim
flying-sheep 384e5b6
Parse tests
flying-sheep 0292a30
Better errors
flying-sheep aa57fb1
rough structure for resolving
flying-sheep c9e2a47
Implement splitting multipaths
flying-sheep e016cfc
docs
flying-sheep 28ccbbf
Fix docs
flying-sheep 6a3effc
really fix docs
flying-sheep 8c83803
maybe this helps
flying-sheep f0a65f7
link
flying-sheep d7cd871
RefPath docs
flying-sheep c867a41
Unexport RefPath
flying-sheep b9cee39
More parse error tests
flying-sheep 0bca090
Progress for resolve_path
flying-sheep f567a6e
Make resolve_path work for layers and obsm/varm
flying-sheep File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about adding an
axis=None
param that defaults to 0 forobsp
and to?
forobsm
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To resolve the ambiguity of indexing into
obsp
(defaulting to rows), and potentially allows indexing into rows ofobsm
(where it defaults to columns).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To what for
obsm
?