Venus/test1 #4
Merged
Venus/test1 #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for scu-virtual-tours ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| "x": -22.96102305361865, | ||
| "y": 1.21997231224456693, | ||
| "z":-9.258993120824082 | ||
| "x": -23.5, |
There was a problem hiding this comment.
I like this position, looks much better and not in the way of the user's path.
| version "7.16.7" | ||
| resolved "https://registry.npmjs.org/@babel/code-frame/-/code-frame-7.16.7.tgz" | ||
| integrity sha512-iAXqUn8IIeBTNd72xsFlgaXHkMBMt6y4HJp1tIaK465CWLT/fG1aqB7ykr95gHHmlBdGbFeWWfyB4NJJ0nmeIg== | ||
| version "7.22.10" |
There was a problem hiding this comment.
I'm not sure how the yarn.lock got changed because it is supposed to only update when there are dependency changes, meaning package.json was changed. I checked out your branch and ran from my side with yarn install, and didn't update the yarn.lock. So, I guess we don't need to worry about it now but keep an eye out if next time your yarn.lock still gets updated despite no dependency changes. We might be able to find a pattern.
Here is the link talking about yarn.lock: yarnpkg/yarn#4379
Inthisstyle66
approved these changes
Aug 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the coordinates of one of the signs; still just mostly getting used to using git for collaboration again.