Added missing SCTP_DATA_{LAST_FRAG,NOT_FRAG} flags #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuexen
reviewed
Sep 18, 2019
tuexen
reviewed
Sep 18, 2019
These can be returned by a SCTP_SEND_FAILED_EVENT notification. See https://tools.ietf.org/html/rfc6458#section-6.1.11
jean-airoldie
force-pushed
the
missing_flags
branch
from
5cc65e1 to
977f4b6
Compare
|
@tuexen Btw what are your thoughts on running clang-format against the repo? |
We use the same sources, process them to take out various platform specific code, and then the resulting code is what is in FreeBSD. The code (more or less) is compliant with the coding style required for FreeBSD. For that reason, I would prefer not to run the code through an automated tool which might not be compliant with the FreeBSD coding style... BTW: Thanks for your submission! |
jean-airoldie
added a commit
to jean-airoldie/usrsctp
that referenced
this pull request
Sep 18, 2019
These can be returned by a SCTP_SEND_FAILED_EVENT notification. See https://tools.ietf.org/html/rfc6458#section-6.1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #372.