This repository has been archived by the owner on Jun 21, 2020. It is now read-only.
BLD: switched from BN.js to JSBI #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #84 +/- ##
========================================
Coverage 98.47% 98.47%
========================================
Files 6 6
Lines 523 523
Branches 46 46
========================================
Hits 515 515
Misses 8 8
Continue to review full report at Codecov.
|
apalepu23
approved these changes
May 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per this issue, the BigNumber library that web3 is not considered secure, so migrated over JSBI. Everything works as before.
PS: Added a new rule to disable
new-capin linter since the.BigNumber()function from the JSBI library breaks it.