Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix start testcontainers fail bug #1313

Merged
merged 3 commits into from
May 2, 2024

Conversation

luky116
Copy link
Contributor

@luky116 luky116 commented Apr 30, 2024

Purpose or design rationale of this PR

When starting the testcontainer container, sometimes the error "creating reaper failed: failed to create container
" will be reported, which may be caused by CI/CD compatibility. According to the official issue discussion of testcontainer-go, disabling TESTCONTAINERS_RYUK_DISABLED can solve this problem.

refer to:testcontainers/testcontainers-go#2172

image

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • [*] test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • [*] No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • [*] No, this PR is not a breaking change
  • Yes

colinlyguo
colinlyguo previously approved these changes Apr 30, 2024
georgehao
georgehao previously approved these changes Apr 30, 2024
@luky116 luky116 dismissed stale reviews from georgehao and colinlyguo via 3e3c76b April 30, 2024 09:33
@georgehao georgehao merged commit 8be70f0 into scroll-tech:develop May 2, 2024
14 checks passed
georgehao added a commit that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants