Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade go-ethereum from scroll-v5.1.6 to scroll-v5.3.0 #1304

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

SamiAlHassan
Copy link
Contributor

Summary

This PR updates the version of go-ethereum in the Makefile from scroll-v5.1.6 to the latest scroll-v5.3.0. The reason the update is to resolve an issue encountered when calling make update:

go: finding module for package github.com/scroll-tech/go-ethereum/crypto/kzg4844
go: scroll-tech/common/types/encoding/codecv1 imports
	github.com/scroll-tech/go-ethereum/crypto/kzg4844: module github.com/scroll-tech/go-ethereum@latest found (v1.10.26), but does not contain package github.com/scroll-tech/go-ethereum/crypto/kzg4844
make: *** [Makefile:12: update] Error 1

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

Thegaram
Thegaram previously approved these changes Apr 28, 2024
@georgehao
Copy link
Member

need also update the l2geth submodule repo

@georgehao georgehao merged commit 0723b46 into scroll-tech:develop Apr 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants