Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(verifier): nil panic due to batch write #911

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

colinlyguo
Copy link
Member

@colinlyguo colinlyguo commented Jul 18, 2024

1. Purpose or design rationale of this PR

  1. fix panic issues.
  2. update da-codec dependency to the latest version in main branch.
2024-07-18 19:28:46 panic: runtime error: invalid memory address or nil pointer dereference
2024-07-18 19:28:46 [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0xcdbc31]
2024-07-18 19:28:46 
2024-07-18 19:28:46 goroutine 116 [running]:
2024-07-18 19:28:46 github.com/scroll-tech/go-ethereum/rollup/rollup_sync_service.validateBatch(0xc0001f26e0?, 0x4?, 0x3?, {0xc003852c00?, 0x2d?, 0x2d?}, 0xc0001b8400?, 0x40?)
2024-07-18 19:28:46     github.com/scroll-tech/go-ethereum/rollup/rollup_sync_service/rollup_sync_service.go:473 +0x91
2024-07-18 19:28:46 github.com/scroll-tech/go-ethereum/rollup/rollup_sync_service.(*RollupSyncService).parseAndUpdateRollupEventLogs(0xc0001f26e0, {0xc006a60840?, 0x2, 0x5?}, 0xc003627e38?)
2024-07-18 19:28:46     github.com/scroll-tech/go-ethereum/rollup/rollup_sync_service/rollup_sync_service.go:252 +0xc88
2024-07-18 19:28:46 github.com/scroll-tech/go-ethereum/rollup/rollup_sync_service.(*RollupSyncService).fetchRollupEvents(0xc0001f26e0)
2024-07-18 19:28:46     github.com/scroll-tech/go-ethereum/rollup/rollup_sync_service/rollup_sync_service.go:185 +0x249
2024-07-18 19:28:46 github.com/scroll-tech/go-ethereum/rollup/rollup_sync_service.(*RollupSyncService).Start.func1()
2024-07-18 19:28:46     github.com/scroll-tech/go-ethereum/rollup/rollup_sync_service/rollup_sync_service.go:138 +0x145
2024-07-18 19:28:46 created by github.com/scroll-tech/go-ethereum/rollup/rollup_sync_service.(*RollupSyncService).Start in goroutine 1
2024-07-18 19:28:46     github.com/scroll-tech/go-ethereum/rollup/rollup_sync_service/rollup_sync_service.go:126 +0xcb

this pr is tested by local testnet.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change

@colinlyguo colinlyguo requested a review from omerfirmak July 19, 2024 08:05
@colinlyguo colinlyguo merged commit de0385e into develop Jul 19, 2024
9 checks passed
@colinlyguo colinlyguo deleted the fix-verifier-nil-panic-due-to-batch-write branch July 19, 2024 16:39
achmand pushed a commit to draganm/go-ethereum that referenced this pull request Aug 13, 2024
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants