feat: defer txpool reorg until worker fetches txns for the next block #905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmountaintop
previously approved these changes
Jul 16, 2024
0xmountaintop
previously approved these changes
Jul 16, 2024
omerfirmak
force-pushed
the
omerfirmak/defer-txpool-reorgs
branch
from
0d79456 to
6cc18b8
Compare
0xmountaintop
previously approved these changes
Jul 18, 2024
jonastheis
previously approved these changes
Jul 24, 2024
omerfirmak
dismissed stale reviews from jonastheis and 0xmountaintop
via
33231f5
jonastheis
approved these changes
Jul 26, 2024
0xmountaintop
approved these changes
Jul 26, 2024
0xmountaintop
pushed a commit
that referenced
this pull request
Jul 30, 2024
0xmountaintop
pushed a commit
that referenced
this pull request
Jul 30, 2024
0xmountaintop
pushed a commit
that referenced
this pull request
Jul 31, 2024
0xmountaintop
pushed a commit
that referenced
this pull request
Jul 31, 2024
0xmountaintop
pushed a commit
that referenced
this pull request
Jul 31, 2024
0xmountaintop
pushed a commit
that referenced
this pull request
Aug 1, 2024
0xmountaintop
added a commit
that referenced
this pull request
Aug 1, 2024
* feat: defer txpool reorg until worker fetches txns for the next block (#905) * fix --------- Co-authored-by: Ömer Faruk Irmak <[email protected]>
achmand
pushed a commit
to draganm/go-ethereum
that referenced
this pull request
Aug 13, 2024
lwedge99
pushed a commit
to sentioxyz/scroll-geth
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
Currently we allow txpool to be reorged immediately after sequencer commits to a new block, then we end up waiting for reorg to be finished to be able to fetch new txns for the next block.
This PR forces reorg to be run in parallel with txn processing in hopes of reducing the time worker waits for it to be finished.
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?