forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(l2geth-verifier): only check last batch of the bundle #904
Merged
0xmountaintop
merged 11 commits into
develop
from
fix-l2geth-verifier-only-check-last-batch-of-the-bundle
Jul 17, 2024
Merged
fix(l2geth-verifier): only check last batch of the bundle #904
0xmountaintop
merged 11 commits into
develop
from
fix-l2geth-verifier-only-check-last-batch-of-the-bundle
Jul 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colinlyguo
force-pushed
the
fix-l2geth-verifier-only-check-last-batch-of-the-bundle
branch
from
July 15, 2024 16:12
d6ad174
to
600ea40
Compare
colinlyguo
force-pushed
the
fix-l2geth-verifier-only-check-last-batch-of-the-bundle
branch
from
July 16, 2024 06:37
42780a5
to
df6a93e
Compare
This reverts commit 4befe9f.
0xmountaintop
previously approved these changes
Jul 16, 2024
Thegaram
previously approved these changes
Jul 16, 2024
tested in a local testnet with Darwin transition:
|
Thegaram
previously approved these changes
Jul 17, 2024
Thegaram
approved these changes
Jul 17, 2024
0xmountaintop
approved these changes
Jul 17, 2024
0xmountaintop
deleted the
fix-l2geth-verifier-only-check-last-batch-of-the-bundle
branch
July 17, 2024 12:01
achmand
pushed a commit
to draganm/go-ethereum
that referenced
this pull request
Aug 13, 2024
…h#904) * fix(l2geth-verifier): only check the last batch of each bundle * refactor function comments * add more logs to debug * fix the bug * Revert "add more logs to debug" This reverts commit 4befe9f. * tweak * TestValidateBatchInFinalizeByBundle * update da-codec dependency * move rawdb.WriteFinalizedBatchMeta outside the loop * use batch writer * change log.Crit to log.Error
lwedge99
pushed a commit
to sentioxyz/scroll-geth
that referenced
this pull request
Aug 27, 2024
…h#904) * fix(l2geth-verifier): only check the last batch of each bundle * refactor function comments * add more logs to debug * fix the bug * Revert "add more logs to debug" This reverts commit 4befe9f. * tweak * TestValidateBatchInFinalizeByBundle * update da-codec dependency * move rawdb.WriteFinalizedBatchMeta outside the loop * use batch writer * change log.Crit to log.Error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
In "finalize by bundle", only the last batch of each bundle is fully verified. This check still ensures the correctness of all batch hashes in the bundle due to the parent-child relationship between batch hashes.
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?