feat(txpool): use GasFeeCapIntCmp to check min fee #901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
Assuming we set
L2GETH_MIN_GAS_PRICE
to48700001
(min base fee + 1), we can now accept transactions with 1 wei tip.Previously,
L2GETH_MIN_GAS_PRICE = 48700001
would have set the minimum tip, butL2GETH_MIN_GAS_PRICE = 1
would have allowed unexecutable legacy txs with 1 wei gas price to enter the txpool.A motivating example with
L2GETH_MIN_GAS_PRICE = 48700001
andbaseFee = 48700000
:effectiveGasTipCapCmp
gasTipCapCmp
gasFeeCapCmp
gasPrice = 1
gasPrice=48700001
gasFeeCap = 48700001, gasTipCap = 1
The previous PR (#825) fixed (1), while this PR aims to fix (2).
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?