Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update L2 base fee formula #891

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Conversation

Thegaram
Copy link

@Thegaram Thegaram commented Jul 9, 2024

1. Purpose or design rationale of this PR

Update according to new cost estimation.

Note: Follower nodes don't verify the base fee, so this is a compatible change.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@Thegaram Thegaram requested review from roylou and omerfirmak July 9, 2024 09:04
omerfirmak
omerfirmak previously approved these changes Jul 9, 2024
@Thegaram Thegaram merged commit f56dbb7 into develop Jul 9, 2024
8 checks passed
@Thegaram Thegaram deleted the feat-reduce-l2-base-fee branch July 9, 2024 10:54
0xmountaintop pushed a commit that referenced this pull request Jul 10, 2024
* feat: update L2 base fee formula

* update test tx hashes
0xmountaintop added a commit that referenced this pull request Jul 10, 2024
feat: update L2 base fee formula (#891)

* feat: update L2 base fee formula

* update test tx hashes

Co-authored-by: Péter Garamvölgyi <[email protected]>
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Aug 27, 2024
* feat: update L2 base fee formula

* update test tx hashes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants