Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add CHANGELOGS-2022-05-04 #88

Merged
merged 21 commits into from
May 17, 2022
Merged

add CHANGELOGS-2022-05-04 #88

merged 21 commits into from
May 17, 2022

Conversation

0xmountaintop
Copy link

No description provided.

@ChuhanJin
Copy link

Can one of the admins verify this patch?

@0xmountaintop 0xmountaintop changed the title add CHANGELOGS add CHANGELOGS-2022-05-04 May 6, 2022
@0xmountaintop 0xmountaintop marked this pull request as ready for review May 6, 2022 08:25
icemelon
icemelon previously approved these changes May 9, 2022
Copy link
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM

docs/change-logs/2022-05-04.md Outdated Show resolved Hide resolved
CHANGELOGS.md Outdated Show resolved Hide resolved
@icemelon
Copy link
Member

@roynalnaruto @otrsk could you help take a look at the pr?

@roynalnaruto
Copy link

I will take a look this week :) 👍

@OrestTa OrestTa self-requested a review May 14, 2022 14:01
@OrestTa
Copy link

OrestTa commented May 14, 2022

@roynalnaruto @otrsk could you help take a look at the pr?

LGTM!

Meta-level: Shall we use GH's 'request reviewer' feature in such situations?

Copy link

@OrestTa OrestTa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HAOYUatHZ let's rebase to main and merge this PR

@scroll-dev scroll-dev merged commit 6e872d0 into zkrollup May 17, 2022
@scroll-dev scroll-dev deleted the change-logs branch May 17, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants