Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clique): allow shadowforking a clique network #828

Merged
merged 18 commits into from
Aug 1, 2024
Merged

feat(clique): allow shadowforking a clique network #828

merged 18 commits into from
Aug 1, 2024

Conversation

omerfirmak
Copy link

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

0xmountaintop
0xmountaintop previously approved these changes Jun 14, 2024
View reviewed changes
0xmountaintop
0xmountaintop previously approved these changes Jun 22, 2024
View reviewed changes
@omerfirmak omerfirmak force-pushed the omerfirmak/clique-shadowfork branch 2 times, most recently from 53f958a to 8be1e87 Compare June 25, 2024 07:30
@omerfirmak omerfirmak mentioned this pull request Jun 25, 2024
Closed
13 tasks
@omerfirmak omerfirmak marked this pull request as draft June 25, 2024 09:07
@omerfirmak omerfirmak force-pushed the omerfirmak/clique-shadowfork branch 4 times, most recently from fea79a7 to 1687dda Compare June 25, 2024 11:08
Thegaram
Thegaram reviewed Jun 25, 2024
View reviewed changes
cmd/geth/main.go Outdated Show resolved Hide resolved
cmd/utils/flags.go Outdated Show resolved Hide resolved
consensus/clique/clique.go Outdated Show resolved Hide resolved
@omerfirmak omerfirmak force-pushed the omerfirmak/clique-shadowfork branch 5 times, most recently from f36fd08 to 8ecc083 Compare July 9, 2024 08:52
@omerfirmak omerfirmak marked this pull request as ready for review July 9, 2024 08:52
colinlyguo
colinlyguo reviewed Jul 10, 2024
View reviewed changes
cmd/utils/flags.go Outdated Show resolved Hide resolved
cmd/utils/flags.go Outdated Show resolved Hide resolved
eth/ethconfig/config.go Outdated Show resolved Hide resolved
@omerfirmak omerfirmak force-pushed the omerfirmak/clique-shadowfork branch from 5847d2d to 8700f92 Compare July 16, 2024 08:14
@omerfirmak omerfirmak force-pushed the omerfirmak/clique-shadowfork branch from 8700f92 to ec32d39 Compare July 31, 2024 10:10
colinlyguo
colinlyguo previously approved these changes Jul 31, 2024
View reviewed changes
0xmountaintop
0xmountaintop reviewed Jul 31, 2024
View reviewed changes
eth/peerset.go Outdated Show resolved Hide resolved
0xmountaintop
0xmountaintop previously approved these changes Jul 31, 2024
View reviewed changes
colinlyguo
colinlyguo previously approved these changes Jul 31, 2024
View reviewed changes
@omerfirmak omerfirmak dismissed stale reviews from colinlyguo and 0xmountaintop via a845dc9 July 31, 2024 16:58
@omerfirmak omerfirmak merged commit 51c7eee into develop Aug 1, 2024
8 checks passed
@omerfirmak omerfirmak deleted the omerfirmak/clique-shadowfork branch August 1, 2024 09:11
0xmountaintop pushed a commit that referenced this pull request Aug 21, 2024
@omerfirmak @0xmountaintop
feat(clique): allow shadowforking a clique network (#828)
6a3f535
0xmountaintop pushed a commit that referenced this pull request Aug 23, 2024
@omerfirmak @0xmountaintop
feat(clique): allow shadowforking a clique network (#828)
706ddbd
0xmountaintop pushed a commit that referenced this pull request Aug 23, 2024
@omerfirmak @0xmountaintop
feat(clique): allow shadowforking a clique network (#828)
938f24c
0xmountaintop added a commit that referenced this pull request Aug 23, 2024
@0xmountaintop @omerfirmak
feat(clique): allow shadowforking a clique network (#828) (#995)
0c312be 
* feat(clique): allow shadowforking a clique network (#828)

* minor fixes

* fix `TestShadowFork`

---------

Co-authored-by: Ömer Faruk Irmak <[email protected]>
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Aug 27, 2024
@omerfirmak @lwedge99
feat(clique): allow shadowforking a clique network (scroll-tech#828)
b3cdb86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thegaram Thegaram Thegaram left review comments

@colinlyguo colinlyguo colinlyguo approved these changes

@0xmountaintop 0xmountaintop 0xmountaintop approved these changes

@jonastheis jonastheis Awaiting requested review from jonastheis

@georgehao georgehao Awaiting requested review from georgehao

Assignees
No one assigned
Labels
bump-version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@omerfirmak @georgehao @Thegaram @0xmountaintop @colinlyguo