Add more data into the execution trace #20
Conversation
Co-authored-by: Haichen Shen <[email protected]>
Co-authored-by: Haichen Shen <[email protected]>
Co-authored-by: Haichen Shen <[email protected]>
Co-authored-by: Haichen Shen <[email protected]>
Co-authored-by: Haichen Shen <[email protected]>
Co-authored-by: Haichen Shen <[email protected]>
Co-authored-by: HAOYUatHZ <[email protected]>
Co-authored-by: Haichen Shen <[email protected]>
core/vm/logger_trace.go
Outdated
| CREATE: {traceSenderAddress, traceNonce}, | ||
| CREATE2: {traceSenderAddress}, |
There was a problem hiding this comment.
missing "created contract address’s accountProof"?
There was a problem hiding this comment.
Do both CREATE and CREATE2 need to be added?
There was a problem hiding this comment.
according to our https://www.notion.so/EVM-Trace-2e476641b6484b71a029c868516ad7b2, both CREATE and CREATE2
core/vm/logger_trace.go
Outdated
| CALL: {traceToAddressCodeHash, traceLastNAddressCodeHash(1), traceOriginProof, traceLastNAddressProof(1)}, | ||
| CALLCODE: {traceToAddressCodeHash, traceLastNAddressCodeHash(1), traceOriginProof, traceLastNAddressProof(1)}, |
There was a problem hiding this comment.
using traceOriginProof here can be wrong. caller may not be the tx sender.
we can retrieve caller_address using "ScopeContext.Contract.CallerAddress"
There was a problem hiding this comment.
This line can show origin is tx sender address.
But this's a mistake we only need contract caller proof, Don't tx's sender proof, that right?
There was a problem hiding this comment.
Yes, that's what I mean. We need caller instead of sender. sometime the caller is the sender, but sometimes not
|
If @ChuhanJin thinks it's urgent we can merge it now, but I think there are some mistakes in thi PR:
|
Co-authored-by: HAOYUatHZ <[email protected]>
|
Can one of the admins verify this patch? |
No description provided.