Extract execution trace from EVM execution and provide subscription API #19

mask-pp · 2022-01-13T06:52:07Z

No description provided.

jules

Overall LGTM, just one point

core/blockchain.go

core/types/l2trace.go

eth/filters/api.go

core/types/l2trace.go

miner/worker.go

core/blockchain.go

core/rawdb/l2trace_test.go

Co-authored-by: Haichen Shen <[email protected]>

.gitignore

eth/filters/filter_system.go

eth/filters/api.go

miner/worker.go

core/rawdb/l2trace.go

core/types/l2trace.go

miner/worker.go

Co-authored-by: Haichen Shen <[email protected]>

icemelon

otherwise LGTM.

@HAOYUatHZ Could you take another look?

core/types/l2trace.go

core/rawdb/schema.go

0xmountaintop · 2022-01-21T07:52:15Z

otherwise LGTM.

@HAOYUatHZ Could you take another look?

np!

ethclient/ethclient.go

eth/filters/api.go

0xmountaintop · 2022-01-21T08:34:07Z

just some nitpicks. otherwise LGTM as well

Co-authored-by: HAOYUatHZ <[email protected]>

icemelon

Some extra nitipicks

eth/filters/filter_system.go

ethclient/ethclient.go

eth/filters/api.go

Co-authored-by: Haichen Shen <[email protected]>

mask-pp and others added 10 commits January 12, 2022 10:38

Create go.yml

22bd648

Merge branch 'scroll-tech:zkrollup' into zkrollup

7bb4d77

Merge from zkrollup and fix conflict

e958633

go mod tidy

ed1a8a3

fix worker_test test case

0efcb0a

fix worker_test test case

9925d5f

Delete go.yml

cae5f4a

Merge branch 'zkrollup' of github.com:mask-pp/go-ethereum into zkrollup

a7072bc

add log content, enable memory trace

65e5539

add tracer pool handler

8368dca

mask-pp requested review from jules and icemelon January 13, 2022 07:28

mask-pp added 7 commits January 13, 2022 15:33

Add comments and format code

3510875

add evmTrace subscribe api

fc18a61

Move the evmTrace struct.

7571c53

Fix miner bug.

f5446f3

upgrade evmTrace api

5da523a

fix bug about evmTracesByHash api

9aea333

Fix the bug about block.timestamp and remove unnecessary copy.

e591323

jules reviewed Jan 19, 2022

View reviewed changes

core/blockchain.go Show resolved Hide resolved

jules approved these changes Jan 19, 2022

View reviewed changes

icemelon reviewed Jan 20, 2022

View reviewed changes

icemelon requested a review from 0xmountaintop January 20, 2022 03:39

icemelon changed the title ~~add evmTrace api and storage~~ Extract execution trace from EVM execution and provide subscription API Jan 20, 2022

mask-pp and others added 3 commits January 20, 2022 12:01

Update eth/filters/api.go

dca013e

Co-authored-by: Haichen Shen <[email protected]>

Upgrade comments.

a3ee4a6

Merge branch 'zkrollup' of github.com:mask-pp/go-ethereum into zkrollup

1e807ae

0xmountaintop reviewed Jan 20, 2022

View reviewed changes

.gitignore Show resolved Hide resolved

mask-pp added 2 commits January 20, 2022 14:02

Merge branch 'zkrollup' of github.com:mask-pp/go-ethereum into zkrollup

5f945a2

Merge branch 'zkrollup' of github.com:mask-pp/go-ethereum into zkrollup

5a309b4

0xmountaintop reviewed Jan 20, 2022

View reviewed changes

eth/filters/filter_system.go Show resolved Hide resolved

0xmountaintop reviewed Jan 20, 2022

View reviewed changes

eth/filters/filter_system.go Outdated Show resolved Hide resolved

0xmountaintop reviewed Jan 20, 2022

View reviewed changes

eth/filters/api.go Outdated Show resolved Hide resolved

miner/worker.go Show resolved Hide resolved

miner/worker.go Outdated Show resolved Hide resolved

Change blockResult to blockResults.

e6f8b78

icemelon reviewed Jan 20, 2022

View reviewed changes

miner/worker.go Show resolved Hide resolved

miner/worker.go Show resolved Hide resolved

Add ReturnValue.

c3a52b6

icemelon reviewed Jan 21, 2022

View reviewed changes

mask-pp and others added 6 commits January 21, 2022 15:26

Update core/rawdb/l2trace.go

e613a6b

Co-authored-by: Haichen Shen <[email protected]>

Update core/rawdb/l2trace.go

adcb40d

Co-authored-by: Haichen Shen <[email protected]>

Update core/types/l2trace.go

a0db670

Co-authored-by: Haichen Shen <[email protected]>

Add indent to the comment and rm json encoding flag.

3b8e1e1

Rm json encoding flag.

db3557c

Update core/rawdb/l2trace.go

ced2001

Co-authored-by: Haichen Shen <[email protected]>

icemelon approved these changes Jan 21, 2022

View reviewed changes

core/types/l2trace.go Outdated Show resolved Hide resolved

core/rawdb/schema.go Outdated Show resolved Hide resolved

0xmountaintop reviewed Jan 21, 2022

View reviewed changes

ethclient/ethclient.go Outdated Show resolved Hide resolved

eth/filters/api.go Outdated Show resolved Hide resolved

mask-pp and others added 5 commits January 21, 2022 21:20

Rm json encoding flag.

e67813d

Merge branch 'zkrollup' of github.com:mask-pp/go-ethereum into zkrollup

fd05da5

Update ethclient/ethclient.go

36c0f14

Co-authored-by: HAOYUatHZ <[email protected]>

Update eth/filters/api.go

e187a7f

Co-authored-by: HAOYUatHZ <[email protected]>

Use as the blockResult prefix flag.

ed57fe2

0xmountaintop approved these changes Jan 21, 2022

View reviewed changes

icemelon reviewed Jan 21, 2022

View reviewed changes

eth/filters/filter_system.go Outdated Show resolved Hide resolved

eth/filters/filter_system.go Outdated Show resolved Hide resolved

ethclient/ethclient.go Outdated Show resolved Hide resolved

eth/filters/api.go Outdated Show resolved Hide resolved

mask-pp and others added 4 commits January 22, 2022 13:26

Update eth/filters/filter_system.go

fc06df6

Co-authored-by: Haichen Shen <[email protected]>

Update eth/filters/filter_system.go

19f9e23

Co-authored-by: Haichen Shen <[email protected]>

Update ethclient/ethclient.go

e5cacd0

Co-authored-by: Haichen Shen <[email protected]>

Update eth/filters/api.go

719ed61

Co-authored-by: Haichen Shen <[email protected]>

mask-pp merged commit 7745fd5 into scroll-tech:zkrollup Jan 23, 2022

0xmountaintop mentioned this pull request Dec 21, 2022

fix: revert block-on-demand (and use constant block time for clique) #193

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Extract execution trace from EVM execution and provide subscription API #19

Extract execution trace from EVM execution and provide subscription API #19

mask-pp commented Jan 13, 2022

jules left a comment

icemelon left a comment

0xmountaintop commented Jan 21, 2022

0xmountaintop commented Jan 21, 2022

icemelon left a comment

Extract execution trace from EVM execution and provide subscription API #19

Extract execution trace from EVM execution and provide subscription API #19

Conversation

mask-pp commented Jan 13, 2022

jules left a comment

Choose a reason for hiding this comment

icemelon left a comment

Choose a reason for hiding this comment

0xmountaintop commented Jan 21, 2022

0xmountaintop commented Jan 21, 2022

icemelon left a comment

Choose a reason for hiding this comment