Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseFold: Add and reimplement some utility functions. #559

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

yczhangsjtu
Copy link
Collaborator

@yczhangsjtu yczhangsjtu commented Nov 6, 2024

Extracting small PRs from #294

There was an implementation of Iterator for iterating through a FieldType. Turns out that it can be replaced with existing tools in iter_tools. This proposes the new implementation.

Also added some other utility functions for type conversion between FieldType and Vec<E>, to avoid match field_type everywhere.

@yczhangsjtu yczhangsjtu changed the title Add and reimplement some utility functions. BaseFold: Add and reimplement some utility functions. Nov 6, 2024
@matthiasgoergens
Copy link
Collaborator

Thanks for breaking down the big PR into more digestible chunks!

Copy link
Collaborator

@matthiasgoergens matthiasgoergens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add in the PR description why we are making this refactoring?

Just a quick note about what task becomes easier or simpler with the new organisation?

Thanks!

mpcs/src/util.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants