Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First of all, thanks for the great script!
I made a couple of improvements in the script. The changes are backward-compatible. Here are the changes:
path.join()
instead of string concatenation for making file names: Using string concatenation is unsafe. Also, it made the output file to have analytics.js path file to be like ".//analytics.js". It would fix this.google-analytics-local.js
tmp
directory: It's already specified in the.gitignore
file, however it was included in the repo.fs.mkdir
, we can make sure that the specified folder is created and exists without prior need to do create it manually.Let me know what you think.
Thanks
P.S. I made some other changes based on this branch to be able to specify the output directory. Currently, it's writing the
folder
path in the script file, which is something that I don't want. Because the changes are not backward-compatible, I didn't include them in this pull request. You can find these changes here.