Skip to content

Commit

Permalink
fix(build): loop pnpm remove external
Browse files Browse the repository at this point in the history
  • Loading branch information
johnlindquist committed Oct 16, 2024
1 parent 17b1c3a commit c781a44
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 119 deletions.
16 changes: 2 additions & 14 deletions build.ts
Original file line number Diff line number Diff line change
Expand Up @@ -228,23 +228,11 @@ try {
const uninstallDeps = external();
console.log(`Removing external dependencies: ${uninstallDeps.join(', ')} before @electron/rebuild kicks in`);
if (uninstallDeps.length > 0) {
if (platform === 'linux') {
execSync(`which npm`, {
stdio: 'inherit',
});
execSync(`npm --version`, {
stdio: 'inherit',
});
execSync(`node --version`, {
stdio: 'inherit',
});
execSync(`echo $NPM_PATH`, {
for (const dep of uninstallDeps) {
execSync(`pnpm remove ${dep}`, {
stdio: 'inherit',
});
}
execSync(`pnpm uninstall ${uninstallDeps.join(' ')}`, {
stdio: 'inherit',
});
}

// const { stdout, stderr } = await exec(`npx electron-rebuild`);
Expand Down
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
"@tailwindcss/forms": "^0.5.9",
"@tailwindcss/typography": "^0.5.15",
"@testing-library/dom": "^10.4.0",
"@testing-library/jest-dom": "^6.5.0",
"@testing-library/jest-dom": "^6.6.0",
"@testing-library/react": "^16.0.1",
"@types/cors": "^2.8.17",
"@types/detect-port": "^1.3.5",
Expand Down Expand Up @@ -130,7 +130,7 @@
"@johnlindquist/clipboard": "^0.1.38",
"@johnlindquist/kit": "latest",
"@pnpm/exec": "^2.0.0",
"@rollup/plugin-commonjs": "^28.0.0",
"@rollup/plugin-commonjs": "^28.0.1",
"@types/express": "^5.0.0",
"@xterm/addon-fit": "^0.10.0",
"@xterm/addon-ligatures": "^0.9.0",
Expand Down Expand Up @@ -182,7 +182,7 @@
"timeago.js": "^4.0.2",
"typescript": "^5.6.3",
"untildify": "5.0.0",
"valtio": "^2.0.0",
"valtio": "^2.1.0",
"xstate": "^5.18.2"
},
"optionalDependencies": {
Expand Down
Loading

0 comments on commit c781a44

Please sign in to comment.