Line 63 added to prevent boolean type from being passed to array_merge #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -59,8 +59,9 @@ public function get_key() { | |||
| * @return mixed Whatever is in those fields. | |||
| */ | |||
| public function get( $field = null, $default = null ) { | |||
| $option_array = get_option( $this->key, array() ); | |||
| $option_array = gettype($option_array) != "array" ? [] : $option_array; | |||
| $data = array_merge( $this->defaults, get_option( $this->key, array() ) ); | |||
There was a problem hiding this comment.
You might need to use $option_array on this line. Otherwise the PR doesn't do anything.
|
Hey, guys. Glad to see all this activity around here. :) Let me know when this is ready for merging. |
|
Yeah, as always, I was late for warm welcome :) :P |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New pull request to fix array_merge problem