-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pr_ci.yaml #506
base: main
Are you sure you want to change the base?
Update pr_ci.yaml #506
Conversation
scribe-org#504 Part of Version needs to be converted to an external link to directs towards the releases on GitHub Updated the pr_ci.yaml to ensure that the Swift environment is installed and ready for running tests or building Swift-based applications as part of the CI process.
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
@andrewtavis, I think our Scribe is using GRDB beta which has swift 6.0. And Github Action flow has yet to launch support for 6.0.0. Can you please try to make use of older GRDB package? |
Yes I think this makes sense. So we need to set a specific version of GRDB :) |
@Mehul721, in the same PR can you please downgrade the GRDB version and push those changes? I think the pr_ci will work. Steps:
|
Provided the steps, so that he can apply those. |
Thanks for the support here, @fabulouiOS-monk! |
@Mehul721, and you can remove the changes made in |
Okay sure I'll do that.Thanks a lot :) |
@Mehul721, I see you are using Xcode 16. right?? If yes, then that's an issue, since in Swift 6.0.0, they have launched a major change regarding concurrency and other stuff, so I guess you need to solve them manually by fixing those. also can you please provide me with SS of the errors in any of the files? |
@andrewtavis, what is your opinion on this? If @Mehul721, make those changes and pushes, I don't think others are having Xcode 16 (using Swift 6.0). And for others, it may show to remove those changes. NOTE: Swift 6.0 is making everything concurrency-safe, hence Mehul is getting those errors. |
I think we can safely update and ask that the community does so. I'm not aware of anyone who would have a problem with this. |
GRDB 6 can indeed create warnings or errors in Xcode 16, if the project opts in for concurrency checking. See groue/GRDB.swift#1509 for workarounds until you upgrade to GRDB 7. |
Yes I am using Xcode 16.The thing with these errors is that they vanish once I enter the files to specifically look at them.But they keep recurring. Came across "data race safety" a number of times.The issue precisely is related to concurrency. |
Thanks so much for the response here, @groue! As always so appreciative of and impressed by your support to the GRDB community. Maybe the thing to do here is upgrade to GRDB 7. We don't have too many queries in the project, and my hope would be that they're fairly standard. Aside from this, we could update this PR with the changes suggested in groue/GRDB.swift#1509 as workarounds :) |
#504 Part of Version needs to be converted to an external link to directs towards the releases on GitHub
Updated the pr_ci.yaml to ensure that the Swift environment is installed and ready for running tests or building Swift-based applications as part of the CI process.