Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pr_ci.yaml #506

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update pr_ci.yaml #506

wants to merge 1 commit into from

Conversation

Mehul721
Copy link

@Mehul721 Mehul721 commented Oct 1, 2024

#504 Part of Version needs to be converted to an external link to directs towards the releases on GitHub

Updated the pr_ci.yaml to ensure that the Swift environment is installed and ready for running tests or building Swift-based applications as part of the CI process.

scribe-org#504 Part of Version needs to be converted to an external link to directs towards the releases on GitHub

Updated the pr_ci.yaml to ensure that the Swift environment is installed and ready for running tests or building Swift-based applications as part of the CI process.
Copy link

github-actions bot commented Oct 1, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and iOS rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-iOS repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CI unit test workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@fabulouiOS-monk
Copy link
Collaborator

@andrewtavis, I think our Scribe is using GRDB beta which has swift 6.0. And Github Action flow has yet to launch support for 6.0.0. Can you please try to make use of older GRDB package?

@andrewtavis
Copy link
Member

Yes I think this makes sense. So we need to set a specific version of GRDB :)

@fabulouiOS-monk
Copy link
Collaborator

@Mehul721, in the same PR can you please downgrade the GRDB version and push those changes? I think the pr_ci will work.

Steps:

  1. Go to project > Scribe
  2. Then go to Package Dependencies
  3. Only for the GRDB.swift, change the branch to Upto next major version
  4. Then put the lower limit to 6.29.3
  5. Refer to image if required:
Screenshot 2024-10-01 at 6 06 59 PM

@fabulouiOS-monk
Copy link
Collaborator

Yes I think this makes sense. So we need to set a specific version of GRDB :)

Provided the steps, so that he can apply those.

@andrewtavis
Copy link
Member

Thanks for the support here, @fabulouiOS-monk!

@fabulouiOS-monk
Copy link
Collaborator

@Mehul721, and you can remove the changes made in pr_ci.yaml file.

@Mehul721
Copy link
Author

Mehul721 commented Oct 1, 2024

@Mehul721, in the same PR can you please downgrade the GRDB version and push those changes? I think the pr_ci will work.

Steps:

  1. Go to project > Scribe
  2. Then go to Package Dependencies
  3. Only for the GRDB.swift, change the branch to Upto next major version
  4. Then put the lower limit to 6.29.3
  5. Refer to image if required:
Screenshot 2024-10-01 at 6 06 59 PM

Okay sure I'll do that.Thanks a lot :)

@Mehul721
Copy link
Author

Mehul721 commented Oct 1, 2024

Screenshot 2024-10-01 at 7 02 21 PM I have updated as recommended but I am still getting these errors and a lot more.Not sure what is wrong.I am getting these errors for Scribe + 10 other languages.

@fabulouiOS-monk
Copy link
Collaborator

@Mehul721, I see you are using Xcode 16. right??

If yes, then that's an issue, since in Swift 6.0.0, they have launched a major change regarding concurrency and other stuff, so I guess you need to solve them manually by fixing those.

also can you please provide me with SS of the errors in any of the files?

@fabulouiOS-monk
Copy link
Collaborator

fabulouiOS-monk commented Oct 1, 2024

@andrewtavis, what is your opinion on this?

If @Mehul721, make those changes and pushes, I don't think others are having Xcode 16 (using Swift 6.0). And for others, it may show to remove those changes.

NOTE: Swift 6.0 is making everything concurrency-safe, hence Mehul is getting those errors.

@andrewtavis
Copy link
Member

I think we can safely update and ask that the community does so. I'm not aware of anyone who would have a problem with this.

@groue
Copy link

groue commented Oct 1, 2024

GRDB 6 can indeed create warnings or errors in Xcode 16, if the project opts in for concurrency checking. See groue/GRDB.swift#1509 for workarounds until you upgrade to GRDB 7.

@Mehul721
Copy link
Author

Mehul721 commented Oct 1, 2024

@Mehul721, I see you are using Xcode 16. right??

If yes, then that's an issue, since in Swift 6.0.0, they have launched a major change regarding concurrency and other stuff, so I guess you need to solve them manually by fixing those.

also can you please provide me with SS of the errors in any of the files?

Yes I am using Xcode 16.The thing with these errors is that they vanish once I enter the files to specifically look at them.But they keep recurring.
Also I have found out two resources that might be helpful.One of them is:-https://developer.apple.com/videos/play/wwdc2024/10169/
Also there is:-
https://www.swift.org/migration/documentation/swift-6-concurrency-migration-guide/dataracesafety

Came across "data race safety" a number of times.The issue precisely is related to concurrency.

@andrewtavis
Copy link
Member

Thanks so much for the response here, @groue! As always so appreciative of and impressed by your support to the GRDB community.

Maybe the thing to do here is upgrade to GRDB 7. We don't have too many queries in the project, and my hope would be that they're fairly standard. Aside from this, we could update this PR with the changes suggested in groue/GRDB.swift#1509 as workarounds :)

@andrewtavis andrewtavis added the hacktoberfest-accepted Accepted as a part of Hacktoberfest label Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted as a part of Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants