Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localization options are not working on live v3.1 application #481

Closed
2 tasks done
andrewtavis opened this issue Jul 31, 2024 · 2 comments
Closed
2 tasks done

Localization options are not working on live v3.1 application #481

andrewtavis opened this issue Jul 31, 2024 · 2 comments
Assignees
Labels
-priority- High priority bug Something isn't working help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Jul 31, 2024

Terms

Behavior

Upon the release of v3.1 it was found that the options to switch the app's language are not showing up in the Settings menu for Scribe. This issue is to devise a fix for this, which will trigger the v3.1.1 release. Prior to release I made a change to the Localizable.xcstrings file as it was constantly being changed when the app was being ran. The change can be seen here.

Ping @Jag-Marcel who has expressed interest in working on this 😊

Device type

iPhone and iPad

Versions

v3.1 and current main

@andrewtavis andrewtavis added bug Something isn't working help wanted Extra attention is needed -next release- Included in the next release labels Jul 31, 2024
@andrewtavis andrewtavis changed the title Localization options are not working on live application Localization options are not working on live v3.1 application Jul 31, 2024
@andrewtavis
Copy link
Member Author

The issue here is that I only have English as a language on my device, so localization options are not presented. Adding German provides a locale switcher between English and German, and also lists the other ones as well. As discussed on Matrix, maybe it would make sense to warn the user that they won't be able to change the app's language if they don't have more than one language enabled in their device settings 🤔

@andrewtavis andrewtavis removed the -next release- Included in the next release label Jul 31, 2024
@andrewtavis andrewtavis self-assigned this Jul 31, 2024
@andrewtavis
Copy link
Member Author

Closed via 8731937 😊 There's now an alert when the user only has one language installed on their device :)

@andrewtavis andrewtavis added the -priority- High priority label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-priority- High priority bug Something isn't working help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

1 participant