Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layouts for keyboards without accent characters need to be fixed #463

Closed
2 tasks done
andrewtavis opened this issue Jun 15, 2024 · 5 comments
Closed
2 tasks done
Assignees
Labels
-next release- Included in the next release bug Something isn't working help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Behavior

An ultimate decision that I made prior to the v3.0 release was to not fix the non-accent character layouts for keyboards as this bug was discovered very late in the release cycle. This should be fixed before the next v3.1 release, which is likely to come in the next few weeks.

An example of the problematic layouts is below:

Simulator Screenshot - iPhone 15 - 2024-06-15 at 12 57 15

Specifically the problem above is that we need there to be spacing before the A key and there needs to be padding in the third key row. These changes would happen based on the state change for the disable accent characters keyboard option. We should check how this effects German, Spanish and Swedish keyboards, and we should also check iPad layouts to see if they're also being negatively effected by this 🤔

Device type

iPhone and iPad

Versions

v3.0 and current main

@andrewtavis andrewtavis added bug Something isn't working help wanted Extra attention is needed -next release- Included in the next release labels Jun 15, 2024
@andrewtavis andrewtavis self-assigned this Jun 16, 2024
@andrewtavis
Copy link
Member Author

Note that iPads should not be effected by this as this option shouldn't show up on iPads. I'll check to make sure that it's disabled :)

@andrewtavis
Copy link
Member Author

Note that the option is not disabled on iPads, so we'll need to figure this out.

@andrewtavis
Copy link
Member Author

andrewtavis commented Jul 26, 2024

Note also that the app hints text is very small on iPads.

Edit: this has been fixed ✅

@andrewtavis
Copy link
Member Author

I'm making a new issue to disable the layout option for iPads :)

@andrewtavis
Copy link
Member Author

Closed by f9f533b 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-next release- Included in the next release bug Something isn't working help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

1 participant