Inconsistent command bar outline behavior

[andrewtavis]

Terms

• I have searched all open bug reports
• I agree to follow Scribe-iOS' Code of Conduct

Behavior

Something that was discussed in #416 is that we're at times seeing inconsistent borders around the command bar. The following is from an iPhone 15 Pro simulator:

And the following is from an iPhone 15.2 Pro simulator:

In the above, the shadows are darker under the buttons, and the border around the command bar is also darker. One way to improve this a bit would be to remove the border around the command bar on light mode, as the shadow is providing enough contrast (is needed on dark mode though).

Open to discussions on this and working with people on it!

Device type

iPhone

Versions

Current main version

[andrewtavis]

CC @Jag-Marcel and @fabulouiOS-monk 😊 Let me know on the idea of removing the border around the command bar! Happy to get suggestions on what's up with the shadows as well :)

[fabulouiOS-monk]

Hi @andrewtavis, I did some work on it and here are the Screenshots with the code updates:
Removed shadow from below the bar

In Dark mode:

In Light mode:

[fabulouiOS-monk]

If all good from your side I can raise PR for it.

[andrewtavis]

Thanks for looking into this, @fabulouiOS-monk :) Looking at it, I think that having the shadow still would be important, but maybe we can try removing the border from the command bar and Scribe key in light mode? Maybe the contrast is enough to also work in dark mode, but let's check in light mode first 😊

[andrewtavis]

Assigning you as we're working on this, @fabulouiOS-monk :)

[fabulouiOS-monk]

Sure, thank you will look into it.

Things I will be looking into:

1. Remove border.
2. How it looks in Light and Dark Mode.
3. Keeping some shadow.

[andrewtavis]

Thanks for the repeat to check our understanding, @fabulouiOS-monk! All sounds good, and looking forward to seeing what you find out 😊

[fabulouiOS-monk]

@andrewtavis, Here are the Screenshots with the border removed and the shadow kept as it is:

Dark mode (I think the contrast is enough to make the difference):

Light mode:

P.S: Took time since working this with my regular job ;)

[fabulouiOS-monk]

@andrewtavis, So do we need to update it or let it be?

[andrewtavis]

Hey @fabulouiOS-monk 👋 Have been at work :) I think we're good for a PR so I can play around with it myself and see 😊 Thanks for the work till now!

[fabulouiOS-monk]

Hey @andrewtavis, Thank you, I raised the PR!

[andrewtavis]

Thanks, @fabulouiOS-monk! I'll try to get to it this weekend with the other PR :) :)

[andrewtavis]

Closed via #438 🚀 Thanks so much for the conversation here and the changes, @fabulouiOS-monk! 😊