Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autocomplete triggering too often #305

Closed
2 tasks done
andrewtavis opened this issue May 13, 2023 · 2 comments
Closed
2 tasks done

Autocomplete triggering too often #305

andrewtavis opened this issue May 13, 2023 · 2 comments
Assignees
Labels
-next release- Included in the next release bug Something isn't working feature New feature or request help wanted Extra attention is needed question Further information is requested

Comments

@andrewtavis
Copy link
Member

Terms

Description

Something that’s been occurring since v2.3 and specifically the issue #256 is that we’re triggering autocomplete too often. Thankfully we do have the ability to replace the word being typed, but it’s a bit of an awkward interaction. Issues include:

  • We’re replacing noun forms where the other form is a valid one (for instance hast in German for du hast Being replaced by Hast that’s also a noun)
  • There are cases where there is only one autocomplete option and then the replace happens while the user is typing a common word

To me it seems like we need to expand the autocomplete lexicon to fix the second issue, and for the first issue maybe words that have lower case versions should not be triggering the space autocomplete. Opinions on this would be welcome though!

Contribution

Would be happy to discuss this with people and figure out how the system can be improved and then work towards updating it :)

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed question Further information is requested -priority- High priority labels May 13, 2023
@andrewtavis andrewtavis added -next release- Included in the next release and removed -priority- High priority labels May 23, 2023
@andrewtavis andrewtavis self-assigned this May 23, 2023
@andrewtavis andrewtavis added the bug Something isn't working label Jun 20, 2023
@andrewtavis
Copy link
Member Author

The following are some errors I’m getting from the current version:

  • Was sollte Ich (capitalization)
  • Weiß ich nicht genau, was wir eigentlich Machenschaft (I wanted to write machen)
  • Allerdings Allerdi* (should have replaced with the word we “wanted to type”)

@andrewtavis
Copy link
Member Author

Closed via 9947e3a. Thanks for the call to help figure this out, @henrikth93! 🥳

SaurabhJamadagni pushed a commit to marekviktor/Scribe-iOS that referenced this issue Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-next release- Included in the next release bug Something isn't working feature New feature or request help wanted Extra attention is needed question Further information is requested
Projects
Archived in project
Development

No branches or pull requests

2 participants