Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hold-to-select design #26

Closed
andrewtavis opened this issue Nov 23, 2021 · 1 comment · Fixed by #140
Closed

Hold-to-select design #26

andrewtavis opened this issue Nov 23, 2021 · 1 comment · Fixed by #140
Assignees
Labels
-next release- Included in the next release design Relates to UX/UI designs feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

andrewtavis commented Nov 23, 2021

This issue is extremely important. Scribe needs to create and implement a proper Bezier path or other design for hold-to-select characters, with this issue including keys popping up when being pressed and removing key pressed coloration where no longer needed.

At time of writing hold-to-select characters are the most glaring design flaw for Scribe as they simply do not look like the UI for system keyboards. As this is very unexpected behavior and also is not properly implemented, any help with designs and implementation would be much appreciated!

One feature of the current design that should be maintained, if only as an option when #16 is finished, is that the alternate character view persists in Scribe, whereas in system keyboards the user needs to continue to hold and drag to select.

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed design Relates to UX/UI designs -priority- High priority labels Nov 23, 2021
@andrewtavis andrewtavis changed the title Appearance: Hold-to-select design Hold-to-select design Nov 23, 2021
@andrewtavis andrewtavis added -next release- Included in the next release and removed -priority- High priority labels Feb 11, 2022
@andrewtavis
Copy link
Member Author

Now that the key designs have been updated, it should be much easier to derive exact key locations and create elements to show a proper key pop up. This will not be implemented for Scribe command buttons as feedback indicates that it's unnecessary, and further their location at the top of the keyboard prevents this feature as Scribe elements cannot exceed the keyboard height.

@andrewtavis andrewtavis linked a pull request Feb 26, 2022 that will close this issue
andrewtavis added a commit that referenced this issue Feb 26, 2022
#26 add key popup and redesign hold-to-select chars
@andrewtavis andrewtavis self-assigned this Apr 7, 2023
Jag-Marcel added a commit to Jag-Marcel/Scribe-iOS that referenced this issue Jul 26, 2024
d9b2226 Merge pull request scribe-org#26 from Jag-Marcel/action-fix
0cb65ed Small fix to action for converting jsons to xcstrings

git-subtree-dir: Scribe/i18n
git-subtree-split: d9b22262f3769545a08bd4772cae20caa2f23c67
wkyoshida added a commit to wkyoshida/Scribe-iOS that referenced this issue Aug 2, 2024
812482a Merge pull request scribe-org#30 from weblate/weblate-scribe-scribe-i18n
446ec73 Translated using Weblate (Spanish)
c553b4e Merge pull request scribe-org#29 from weblate/weblate-scribe-scribe-i18n
80c0a4e Translated using Weblate (Swedish)
563a96f Translated using Weblate (Spanish)
416a9e4 Translated using Weblate (German)
019a084 Translated using Weblate (English (United States))
41f7450 Translated using Weblate (English (United States))
74263da Translated using Weblate (English (United States))
ba64ae1 Translated using Weblate (English (United States))
0e2f944 Minor updates to readme headers and text
d9b2226 Merge pull request scribe-org#26 from Jag-Marcel/action-fix
0cb65ed Small fix to action for converting jsons to xcstrings
cd28e5e Merge pull request scribe-org#25 from weblate/weblate-scribe-scribe-i18n
dc922d8 Translated using Weblate (Swedish)
997460b Translated using Weblate (Spanish)
a99deb4 Translated using Weblate (German)
eff6dee Merge pull request scribe-org#24 from Jag-Marcel/new-strings
7ad62b4 Merge branch 'main' into new-strings
b020823 Merge pull request scribe-org#23 from weblate/weblate-scribe-scribe-i18n
463dd85 New strings for Scribe-iOS translation picker
dde9e54 Translated using Weblate (Swedish)
65d4274 Translated using Weblate (Swedish)
f2c989d Translated using Weblate (Swedish)
d230853 Merge pull request scribe-org#22 from Jag-Marcel/minor-fix
dc219d4 Minor fix to conversion script

git-subtree-dir: Scribe/i18n
git-subtree-split: 812482a104212e84ccb7aa620e580e9130a6581b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-next release- Included in the next release design Relates to UX/UI designs feature New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant