Skip to content

Commit

Permalink
#7 update changelog, fix conjugation table vals, fix plural bug
Browse files Browse the repository at this point in the history
  • Loading branch information
andrewtavis committed Aug 15, 2024
1 parent 2619fc2 commit dc554ed
Show file tree
Hide file tree
Showing 3 changed files with 15 additions and 3 deletions.
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ Emojis for the following are chosen based on [gitmoji](https://gitmoji.dev/).

# [Upcoming] Scribe-iOS 3.2.0

### ⌨️ New Keyboards

- Adds an English keyboard ([#7](https://github.com/scribe-org/Scribe-iOS/issues/7)).

### ✨ New Features

- Scribe commands can now be triggered directly on a selected word by pressing the Scribe key and then choosing which command to use ([#141](https://github.com/scribe-org/Scribe-iOS/issues/141)).
Expand All @@ -31,6 +35,10 @@ Emojis for the following are chosen based on [gitmoji](https://gitmoji.dev/).

- Localization strings for English, German, Swedish and Spanish have been added for all remaining app texts ([Scribe-i18n#28](https://github.com/scribe-org/Scribe-i18n/issues/28)).

### 🐞 Bug Fixes

- The plural command now reacts to the capitalization of the input word when a word that's already plural is entered.

# Scribe-iOS 3.1.0

### ✨ New Features
Expand Down
4 changes: 2 additions & 2 deletions Keyboards/KeyboardsBase/KeyboardViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1559,9 +1559,9 @@ class KeyboardViewController: UIInputViewController {
conjugationToDisplay = simple[0] + "/" + conjugationToDisplay
} else if index == 1 && allConjugations[index] == "presPart" {
if enConjugationState == .present {
conjugationToDisplay = "am/are/is/" + conjugationToDisplay
conjugationToDisplay = "am/are/is " + conjugationToDisplay
} else {
conjugationToDisplay = "was/were/" + conjugationToDisplay
conjugationToDisplay = "was/were " + conjugationToDisplay
}
} else if index == 3 && allConjugations[index] == "presPerfTPS" {
conjugationToDisplay = "have/" + conjugationToDisplay
Expand Down
6 changes: 5 additions & 1 deletion Keyboards/KeyboardsBase/ScribeFunctionality/Plural.swift
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,11 @@ func queryPluralNoun(queriedNoun: String) {
proxy.insertText(wordToReturn + getOptionalSpace())
}
} else {
proxy.insertText(noun + getOptionalSpace())
if inputWordIsCapitalized {
proxy.insertText(noun.capitalized + getOptionalSpace())
} else {
proxy.insertText(noun + getOptionalSpace())
}
commandState = .alreadyPlural
}
}

0 comments on commit dc554ed

Please sign in to comment.