Improve convert_jsons_to_strings.py
#64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing for missing 'jsons' folder.
…files - Pre-loaded all language JSON files into a dictionary to minimize redundant I/O operations. - Modified the XML file generation loop to use pre-loaded translations for each language. - Improved code readability and performance by reducing file reads inside the loop.
…generated by the script to prevent 'directory not found' errors when testing the reverse conversion (JSON to strings).
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and i18n rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
andrewtavis
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Thanks so much for this, @OmarAI2003! Feel free to jump into strings_to_json and we can then maybe move on to the MSA localization 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuing the work discussed here to the localization of JSON files this PR includes the following changes :
Pre-loaded JSON files:
strings.xmlfiles.Improved Error Handling:
jsonsfolder exists before processing, preventing potential runtime errors.3 Generated missing 'hi' folder:
hilanguage folder generated by this script to preventdirectory not founderrors when testing the reverse conversion from JSON to strings.Related issue:
#57