Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:Added escape character for \n #42

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

angrezichatterbox
Copy link
Member

The pull request implements escape characters for \n so that the string.xml would have a \n instead of a new line coming up.

#27

Copy link

github-actions bot commented Aug 27, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Localization rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo

@andrewtavis
Copy link
Member

Just checking here, @angrezichatterbox, with this we do not need to change anything for the strings in Scribe-Android and they'll just be good to go?

@andrewtavis andrewtavis self-requested a review August 27, 2024 16:25
@angrezichatterbox
Copy link
Member Author

Just checking here, @angrezichatterbox, with this we do not need to change anything for the strings in Scribe-Android and they'll just be good to go?

I have cross-checked the strings. I assume there aren't any more escape characters to add to the current set of strings. I have taken in most of the cases possible.

@andrewtavis
Copy link
Member

Ok, nice :) I'll merge this soon and then move it over to the Android PR :)

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @angrezichatterbox! Really appreciate you coming in with such a quick fix 🙏

@andrewtavis andrewtavis merged commit 1e07813 into scribe-org:main Aug 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants