Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:Added special character replacement in the Script #38

Merged

Conversation

angrezichatterbox
Copy link
Member

This pull request considers the special characters used in the JSON to be properly handled by the JSON to XML Python script. This makes sure that there would be no issues when using the string.xml in the Android application.

Copy link

github-actions bot commented Aug 14, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Localization rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution
    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local activist repo

@andrewtavis andrewtavis self-requested a review August 14, 2024 06:01
@andrewtavis
Copy link
Member

Thanks for working with the system we have, @angrezichatterbox 😊 Hoping that we'll all be seeing the benefits of it soon once the infrastructure is finalized and we're just bringing localizations in 🌐

@andrewtavis andrewtavis merged commit 5f38e75 into scribe-org:main Aug 14, 2024
1 check passed
@andrewtavis
Copy link
Member

andrewtavis commented Aug 14, 2024

In your Scribe-Android branch, @angrezichatterbox, what you need to run is:

git subtree pull --prefix /app/src/main/assets/i18n [email protected]:scribe-org/Scribe-i18n.git main --squash

This should update Scribe-18n with the latest changes :)

Let me know if there are any problems though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants