-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add loading and exporting functions to utils #83
Add loading and exporting functions to utils #83
Conversation
Signed-off-by: Shashank Mittal <[email protected]>
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Data rooms once you're in. It'd be great to have you! Maintainer checklist
|
Signed-off-by: Shashank Mittal <[email protected]>
Hey @andrewtavis ! Added these three functions |
Hey @shashank-iitbhu! 👋 |
Yes, this can be reviewed. Haven't added the doc strings yet. Also, let me know if tests should be added for these functions? |
…mon-func-for-loading-and-exporting
…m:shashank-iitbhu/Scribe-Data into add-common-func-for-loading-and-exporting
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
This is really great, @shashank-iitbhu :) Minor inline comments coming shortly 😊 |
src/scribe_data/extract_transform/languages/English/nouns/format_nouns.py
Outdated
Show resolved
Hide resolved
src/scribe_data/extract_transform/languages/English/nouns/format_nouns.py
Outdated
Show resolved
Hide resolved
Am thinking that the above changes should be pretty straightforward, @shashank-iitbhu 😊 Happy to merge once they come through! |
Signed-off-by: Shashank Mittal <[email protected]>
Signed-off-by: Shashank Mittal <[email protected]>
src/scribe_data/extract_transform/languages/English/nouns/format_nouns.py
Outdated
Show resolved
Hide resolved
I added in a couple of changes here to bring our tooling a bit into the next generation: specifically adopting Ruff over Black for formatting. @shashank-iitbhu, I'd suggest you to install the VS Code extension for Ruff so that formatting is taken care of for you :) Aside from this the only changes to the committed code was to make all arguments for the functions be explicitly passed 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this, @shashank-iitbhu! All of this refactoring is really coming along! 🚀 Will send a message to the data channel with some info about some of the other changes I included in here :)
Contributor checklist
Description
Added common functions for loading and exporting data to utils.py.
Added
get_language_dir_path
,load_queried_data
,export_formatted_data
in utils.py .Related issue